[BUGFIX] Async relational validations resolve with fake positive #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been constant issues where after
validate
orvalidateAttribute
, the returned validations are stillvalidating
. This was due to how relational validations were handled.Changes proposed:
Unfortunately, the only way to combat this issue with the current architecture is to recursively call
validate
until the validations are truly done validating. In the case of ahasMany
orbelongsTo
, validate should only be called twice.Without relational validations,
validate
will only called once.Tasks: